Re: Re: [bitpim-cvs-checkins] bitpim midifile.py,NONE,1 .1 fileinfo.py,1.11,1.12

>The reason I didn't take that approach was because I wanted to mainly
>deal with correct MP3 files (ie without gratuitious junk at the
>begining).

I remember you mentioned something like that previously.  But as you also stated, I need that patch to work with the MP3 files generated by ffmpeg.  btw, can you double check the ID3 format?

>Is the backing up one byte still needed as you fixed the other frame >length bugs?

Since you have the check in place, I just left it there; who knows what else might be screwed up out there.

>I think you'll find I don't have any copyright on that file :-)

My apology.  I blamed it on lazy-copy-and-paste :-)

>As a stylistic issue there is no need for code like that.  Just name >the variable self.time_delta.  You can make it a property in the >future without affecting any calling code.  It is also generally not >recommended to use double underscores unless you expect derived >classes to want to create something with the same name.

I guess that's the mentality carried over from my C++ days, in which all instance variables are supposed to be private and exposed only via accessors.  The property feature of Python allows me to do that very nicely and conveniently.

>I presume a variant of the code could also be used to do clipping of
>midi files, although that isn't very high up on the priority list.

Yes, I was waiting for your conversion dialog to figure out how best to allow users to do that.

-Joe Pham



______________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/month -visit http://www.netzero.com/surf to sign up today!



-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt