Re: [bitpim-cvs-checkins] bitpim com_samsungscha650.py,1.40,1.41

> +    # fill in your own image origins using these
> +    stockimageorigins={
> +        "images": {'meta-help': 'General images'},
> +        "mms": {'meta-help': 'Multimedia Messages'},
> +        "drm": {'meta-help': 'DRM protected images'},
> +        "camera": {'meta-help': 'Camera images'},
> +        "wallpapers": { 'meta-help': 'Generic wallpapers'}
> +        }

You shouldn't copy those from the parent class.  You should be inheriting
them.  (ie if the com_phone.Profile is modified to add more fields then
they should be picked up automatically).  See the vx6000 code.

> +    stockimagetargets={
> +        # You need to override in your GetTargetsForImageOrigin function and update
> +        # for ImgFileInfo fields
> +        "128x128 BMP wallpaper": {'meta-help': 'Display as wallpaper'},
> +        "128x128 PNG wallpaper": {'meta-help': 'Display as wallpaper'},
> +        "128x160 BMP wallpaper": {'meta-help': 'Display as wallpaper'},
> +        "128x160 PNG wallpaper": {'meta-help': 'Display as wallpaper'},
> +        }

Same story with this.  The constants starting with 'stock' are defined in
com_phone.Profile *only*.  Each phone model should then inherit and update
(that is what the getkv thingy is all about) into their own variable.

BTW why is the above like it is?  Presumably 128x128 is wallpaper and
128x160 is fullscreen.  Use those as the targets.

For the format (BMP or PNG), I can understand the desire to offer the
users flexibility but I would *much* rather BitPim just does the right
thing and users don't have to know or care.  Is one or other format more 
preferable 99% of the time?

If there is some fundamental reason we have to offer both formats, it
is also possible to have a format of 'BMPorPNG' and have the save code
make the decision at that time of which to use.

Roger


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click