Re: bitpim-cvs-checkins digest, Vol 1 #541 - 1 msg

On Sun, 2005-04-17 at 23:03,
[email protected] wrote:

> Today's Topics:
> 
>    1. bitpim gui.py,1.191,1.192 sms_tab.py,1.10,1.11 (Joe Pham)
> 
> --__--__--
> 
> ...

> Index: gui.py
> ===================================================================
...
> -    def OnDetectPhone(self, _):
> -        if wx.IsBusy():
> -            wx.MessageBox("BitPim is busy.  You can't change settings until it has finished talking to your phone.",
> -                         "BitPim is busy.", wx.OK|wx.ICON_EXCLAMATION)
> -            return
> -        self.__detect_phone()
> +    if guihelper.IsMSWindows():
> +        # only available on Windows
> +        def OnDetectPhone(self, _):
> +            if wx.IsBusy():
...

This change breaks BitPim on Linux.  (Won't startup because
OnDetectPhone is not defined when the menu's are setup).

DetectPhone seems to work under Linux, so I don't think it needs to be
windows only anyway.

				Stephen




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click