Re: Patches - support for LG-VX3200

Did a fresh grab of the the repository. All of my changes appear to be in
and working including the Help.

All of your comments below are great. I need a little time to look at each
one and respond. Just wanted to let you know that the patches are intact.

Bruce

>> I have submitted a tarball to Roger with the barebones bits to support
>> the LG-VX3200 in BitPim.
>
> The patches have been applied.  I made one change which is to call the
> format "lgbit" rather than plain "bit".  You can double check  what I
> did at http://bitpim.org/cvslog/ and the help on the main
> site has been updated with your content as well.
>
> Currently the phone will only show up when running from CVS.  When you
> are sure the code has been correctly patched then post here
> and I'll move it to the production section.
>
> Some comments:
>
>  - I really don't like the SimpleFileCache class.
>    com_brew.BrewProtocol.DirCache almost does what you need.
>    It would be appreciated if you can update that class and
>    change your code to use it.  My suggestion is to add a
>    parameter to the constructor that turns on caching file
>    contents as well as the directory entries.
>
>  - I also don't like doing file format conversions in the
>    communications thread.  There is no chance to interact
>    with the user if anything goes wrong.  The file formats
>    should just be displayed by BitPim.  You can look at
>    how BCI (Brew Compressed Image) is handled.
>
>  - The audio filename munging is also unfortunate.  I think it
>    may be better to just completely remove it when coming off
>    the phone and add it back on when writing back.  (This is
>    part of the reason fileinfo was written - we need to understand the
> actual format rather than what the extension is.)
>    If the extension is removed then we have a problem giving
>    the files to other programs on the same operating system.
>
>    However that isn't a bad thing.  It is about time
>    we moved to a model of storing media stuff in numbered
>    files in our data directory and showed names in the UI
>    appropriate for the phone etc.  Any interactions that
>    need to be done with the OS can be done by creating
>    a copy of the file with whatever naming and extensions
>    make sense for the OS.  This scheme will let us do
>    synchronization of media etc and is analogous to the
>    phone book except we don't store the actual file contents
>    in the database.
>
>  - The existing function in vx4400 that deals with media
>    sucks (it is large, convoluted, uses many short variable
>    names etc).  Maybe someone can simplify and refactor it.
>
> Roger
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by Yahoo.
> Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
> Search APIs Find out how you can build Yahoo! directly into your own
> Applications - visit
> http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
> _______________________________________________
> BitPim-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bitpim-devel


-- 
Bruce Schurmann
BitPim LG-VX3200 dev




-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005