Re: Updates to vx8100
"Roger Binns" <[email protected]>
| Newsgroups | gmane.comp.mobile.bitpim.devel |
|---|---|
| Message-ID | <001301c59c9a$58a5e190$3501a8c0@rogersqyvr14d3> |
> Source attached. (com_lgvx4400.py, p_lgvx4400.p, com_lgvx8100.py, > p_lgvx8100.p) In future please use diff -u as detailed on the developer page http://bitpim.org/developer.html com_lgvx4400.py: What is the purpose of speeddialoffset? Is the 8100 doing something bizarre like not starting the file at one? (The other phones that use one for voicemail ignore the entry but it is there.) I also don't like the change of the unset alarm for all LG models. The LG calendar code does need to be redone, probably from scratch. If you have the time and inclinatio, I would suggest doing that and we can make values like that be model dependent. Removing the comment doesn't remove what it states. You cannot save to an origin of camera. Assuming the 8100 is like the 8000 and 7000, then there is no seperate origin for camera so that is all immaterial. com_lgvx8100.py: You seem to have figured out the calendar on that phone. However it seems to be reading and writing newschedule.dat. Is that really the name of the file (ie the new prefix). It would be great if you can document the format and we can try to get unified improved LG calendar support. Unless the format is completely different - ie new :-) You can save it in analyser format to make life easy. It also looks like you can seperately set the alarm for a calendar event to vibrate. Is that in addition to the ringtone? Anyway it seems like you give vibrate special treatment. My concern is that if a user read their calendar into BitPim and then wrote it back out, the vibrate information would be stripped. Post here what semantics you need (eg is vibrate just another ringtone or is it a flag) and Joe can provide a solution to preserving the value. p_lgvx4400.p: Just awaiting the speed dial clarification. p_lgvx8100.py: That class needs to go into a seperate file. We'll start a file named prototypeslg.py for the LG protocol specific types (LGCALDATE can also be pulled out of prototypes.py). (BTW prototypes is short for protocol types not the C header sense). ------ I have merged any of the above yet, awaiting your feedback ... Roger ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf