RE: SMS on VX4400

> The common SMS code seems to work ok.  I do have a few suggestions:
>
> 1. Various file names and limits should either be defined as
> class variables of the Phone class, or in the protocol class.
>  That makes it easier for other phones to subclass without
> making unecessary code changes.
Yes this would be better, I'll try to get something to you after the build.

>
> 2. The Saved messages can either be Inbox or Outbox messages.
>  On the 4650, the 1st word determines the type.
This is instead of the filename being different?
Is the rest of the code similar enough that there is common code to be
shared, the decoding of the 7-bit ascii for instance. I tried to break up
the SMS stuff so that if a phone was different the various functions could
be overloaded as required, do you have any ideas?

> 3. Avoid using unknownxx as the names of valid fields.

Would 'padxx' be better?


Simon



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf