RE: Changes
"Simon C" <[email protected]>
| Newsgroups | gmane.comp.mobile.bitpim.devel |
|---|---|
| Message-ID | <002a01c631f4$43a3fe40$0201a8c0@HOME> |
> >I wanted to replace the current settings dialog that pops up when > >bitpim runs for the first time, > > I understand what you're trying to do. However, I have 2 suggestions: > 1. Use existing processing path instead of having extra one > (ie, call detect_phone in the main loop in its own thread as > if it was activated from the menu) I did not want to change the current design any more than adding autodetect as a precursor to the settings dialog being shown. If this were moved to run as if the menu option were pressed it would not be possible to present the settings dialog prior to the main window in the case where no phone was detected and there was no valid configuration. 2. Having a popup display > on top of the splash screen is not that attractive! I'll remove the message when the phone is detected, having to click everytime it works is kindof annoying. If a new phone is detected it will still ask for the name, and an error will still be displayed when no phone is detected. > >however for some reason the autodetect does not work and it > is detected > >as "other CDMA". > > My guess is that the firmware is not quite ready to talk to > the PC. I'd go with Roger's suggestion with putting in a > delay before detecting it. Since this is phone's specific, > the delay would be passed from the phone module (similar to > the reboot request). I'll remove the new option I added, I understand the point you make. I'll put a delay into the notification code. I don't see how this can be phone specific as we don't know what model we are going to be detecting and we could potentially run through all the phones we support, we would need to pick the lowest comon denominator if it was in the profile. I was thinking that a hidden parameter "device_connect_detect_delay" could be added to the code. Simon ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642