RE: Phone detection changes
Simon C <[email protected]>
| Newsgroups | gmane.comp.mobile.bitpim.devel |
|---|---|
| Message-ID | <[email protected]> |
> >but it that was a style issue, > > It was more than a style issue, I wouldn't have made > the changes if it were. The main goal I had was to remove the config dialog when bitpim ran for the first time. I must be missing your point about the reason you did not like the approach I took. Can you explain where my reasoning below is flawed. The config dialog runs and completes *before* the worker thread has started or the main window has been initialised. In order to get rid of the config dialog it is necassary to run phone detection prior to the main thread starting, this means that the existing phone detect code path cannot be used unless we move the first time phone detection until after the main window has initialised. This would have to be synchronised with the auto detection and only shown if it failed and it was the first time bitpim was run, this will require extra code and will mean that the main window will be running without a valid configuration (I not sure if this will even work?) Given the fact that there will be a different way of running phone detection for the first time bitpim is run it does not really matter whether the detect at startup feature uses this new code or the existing version. I prefer not to use the existing one because it pops up a message saying the phone was found, kindof annoying, I think notification on failure is the only thing we need to report for auto detection. ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642