Re: LG-VX code cleanup
Nathan Hjelm <[email protected]>
| Newsgroups | gmane.comp.mobile.bitpim.devel |
|---|---|
| Message-ID | <[email protected]> |
I have tested the patch with the VX-8600 and VX-8700 and I can further test the VX-6100, VX-7000, VX-8000, and possibly the VX-8100, VX-8300, and VX-8500. I don't have any access to the VX-5300, VX-9800, or VX-9900. So, the getfundamentals code and DM code changes have been fairly well. My primary concern is how my patch affects the VX-9800 and VX-9900. Some of the changes were necessary to add V99VZV02 support to the VX-9900 module and others were just code cleanup. I removed several methods while researching the changes needed due to a change in inheritance (VX-8100 to VX-8500). Those methods were deleted based on how they *didn't* differ from those inherited from the VX-8100 module (now through the VX-8500 module). Can anyone on the mailing list test this patch on the VX-9800 and the VX-9900 (especially V99VZV02) or any other LG-VX phone for that matter? I don't have a problem with deferring this patch to after 1.0.0 so I can get all these changes tested. :) -Nathan On Sunday, June 03, 2007, at 04:24PM, "Joe Pham" <[email protected]> wrote: >Thanks for the path. This patch affects quite a few LG phones. >Unless you had a chance to test each and everyone of them, I'd prefer >to defer this patch until after release 1.0.0 (except for the initial >VX9400 support). > >-Joe Pham > > > >------------------------------------------------------------------------- >This SF.net email is sponsored by DB2 Express >Download DB2 Express C - the FREE version of DB2 express and take >control of your XML. No limits. Just data. Click to get it now. >http://sourceforge.net/powerbar/db2/ >_______________________________________________ >BitPim-devel mailing list >[email protected] >https://lists.sourceforge.net/lists/listinfo/bitpim-devel > > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/