Re: LGDM Phone patch

"Joe Pham" <[email protected]>
Newsgroups gmane.comp.mobile.bitpim.devel
Message-ID <[email protected]>
I finally got some time to look at the patch and I have a few 
suggestions:

1. Need to determine when a phone dropped off DM and needs re-enter 
DM, vs when it failed to enter DM in the first place (which should be 
ignored rather than retry).

2. Your wrappers for file ops need to be done per instance vs per 
class basis.  (Your scheme of using a class variable does not seem to 
work anyway).

3. Inside your wrappers, just check if DM has been achieved, if not 
then try it rather than catching for BrewAccessDeniedException.

-Joe Pham

_____________________________________________________________
Click to find local singles for dating, romance and fun
http://track.netzero.net/s/lc?u=http://tagline.untd.us/fc/Ioyw6ijm1uSd6H6iB6wFjd5P5l808R0S9HWrGyQbRBrT4hnj8UhyPi/



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.