Re: LGDM Phone patch

> Let me rephrase: only retry if you successfully transitioned to DM,
> else just ignore.  Another approach is to mirror what LG does: try to
> enter DM for every ops (for those phones that need it).

I see what you mean. I corrected the code to raise the  
com_brew.BrewAccessDeniedException if it fails to enter DM. This  
implementation should be almost entirely transparent to any phones  
that don't need/use DM. :)

>> Can you explain what you mean by the class variable scheme not
>> working?
>
>         # don't call setup code more than once
>         if self._DM_inited == 0:

Ah, I think I see what you mean. I changed how my LGDMPhone code is  
initialized. Take a look and let me know if it is more to your  
liking. :)

Also take a look my modifications to the sendbrewcommand code. With  
this patch it will now throw com_brew.BrewAccessDeniedException if  
the phone returns any sequence with \x4b as the first byte and \x1c  
as the third. Seemed silly to check for access denied with each  
possible command.


-Nathan

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

_______________________________________________
BitPim-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bitpim-devel