Re: LGDM Phone patch

Your changes look good for the most part. One thing that will not work is your hardcoding of the DM version. Verizon is adding DMv5 with each new firmware. By always attempting DMv5 and falling back on DMv4 these new firmwares can be supported without any change to Bitpim. Trying DMv5 has no apparent negative effect on non-DM phones and just returns a command not supported error  (confirmed with a VX-8600v2 and VX-8300v2). I would suggest removing the hardcoding of the DM version (as it was in my patch). As it is written now the VX-8600v3 and VX-9900v2 are not supported (DMv5).

Also, operating on a timer should work fine but, again, trying the command and getting the access denied has no apparent negative effect.

-Nathan

On Friday, June 29, 2007, at 06:16PM, "Joe Pham" <[email protected]> wrote:
>I've made some changes to the LGDMPhone class and committed the 
>changes.  Please take a look at the changes to see if they'd work for 
>you.
>
>-Joe Pham
>
>_____________________________________________________________
>Turn your passion into a profession.  Click here to find a film school near you.
>http://track.netzero.net/s/lc?u=http://tagline.untd.us/fc/Ioyw6ijlSMOzpBp8XZUY7JR0zywXFMU6iNGfobYMzg4c8IWfk2mvqs/
>
>
>
>-------------------------------------------------------------------------
>This SF.net email is sponsored by DB2 Express
>Download DB2 Express C - the FREE version of DB2 express and take
>control of your XML. No limits. Just data. Click to get it now.
>http://sourceforge.net/powerbar/db2/
>_______________________________________________
>BitPim-devel mailing list
>[email protected]
>https://lists.sourceforge.net/lists/listinfo/bitpim-devel
>
>

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/