Re: LGDM Phone patch

On Jun 29, 2007, at 8:53 PM, Joe Pham wrote:

>> One thing that will not work is your hardcoding of the DM version.
>
> It's not hardcoded, subclass can change it via "setDMversion()".

It is hardcoded in the sense that each module is has a hardcoded DM  
version. Now, if Verizon changes the DM version to 5 for a phone with  
a new firmware, as they did with the VX-8600, the way it is written  
now will require a new build of Bitpim that reflects the change. If,  
on the other hand, DMv5 is always tried such a change by Verizon will  
not break support for the phone in the current build. If DMv5 is  
tried on a phone that does not use it at this time it will respond to:
\xFE \x00 \x00 \x00 \x00 \x00 \x00

with:
\x13 \xFE \x00 \x00 \x00 \x00 \x00 \x00

That error can be (and is) caught by a try/except then ignored. The  
code can then fall back on DMv4, as it was originally written. An  
instance variable could be set indicating DMv5 is not available to  
avoid trying it again. This will provide maximum support for  
supported phones (and not require additional code in any phone module).

>> operating on a timer should work fine
>
> That was meant for those phone models that may get kicked out of DM
> after some amount of time.  Obviously, one has to determine, or
> guess, how long that is.

I am unsure how long it takes the phone to kick out of DM. The  
VX-8600 takes between 10 and 60 seconds (I may have seen longer). One  
possible explanation of this variability is that the phone re-enters  
DM X seconds after the last command. X is very small (on the order of  
seconds) on the VX-9400 and reasonably long on the VX-8600. If you  
wish to use a timer I would suggest making it very short (that might  
defeat the purpose of using a timer in the first place).

>> trying the command and getting the access denied has no apparent
>> negative effect.
>
> Not sure what you meant, is that a good or bad thing?

No negative effect means that a command (requiring DM) can be tried  
and then, if the phone returns "access denied", be retried after (re) 
entering DM.

Also, I do not see the VX-9400 or sendbrewcommand changes.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/