Re: Early VX-8550 support
Nathan Hjelm <[email protected]>
| Newsgroups | gmane.comp.mobile.bitpim.devel |
|---|---|
| Message-ID | <[email protected]> |
On Sunday, July 15, 2007, at 10:35PM, "Joe Pham" <[email protected]> wrote: >> - Early VX-8550 support. All file formats have been decoded. >> - Cleaned up getfundamentals code. (Joe, this is from an earlier >>patch of mine.) > >Committed with minor changes. > >> - A bad brew command will no longer raise a phonebook busy error. > >I need more info on how this change works and how it affects other LG >phone models. The change shouldn't have any effect on other LG phones. The line the patch modifies is one I added about a month ago that interpreted any difference between the first two bytes in the request and the same bytes of the response as a phonebook busy error (the VX-8700 returns something similar to 0xff 0xff if the phonebook is busy). There is a bug in that line of code as it interprets a bad brew command error as a phonebook busy error. The patch fixes this bug allowing the if ord(data[0])==0x13: line to catch the error and throw the proper exception. -Nathan ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/