Re: VX-8700 Groups patch and other stuff

Yes, it works on the 8700, 8550, and 10000. I haven't tested it on the 8800 but that phone is nearly identical to the 10000.

Attached is an updated version of the patch that moves DEBUG1 to com_lgvx8700.py. I forgot to move it before I ran diff.

I am also attaching a patch which corrects the issue where dev.null (and other special files) are treated as directories. Special files have type 0x0f in the directory listing.

I am almost finished moving your new phonebook code into com_lgvx8550.py. The VX-8550 also has a HPE entry and a record_id.dat file as does the VX-10000. I should have a patch tested and ready this evening once I figure out a good way to handle malformed yet valid phone number entries.

-Nathan
 
On Tuesday, July 15, 2008, at 09:13PM, "Joe Pham" <[email protected]> wrote:
>>Attached is a patch that moves the VX-9100 group read/write into the 
>>VX-8700.
>
>Thanks for the patch.  It'll be in the next test release, which would be next Monday btw.  I assume you or one of your helpers had a chance to test this out?
>
>-Joe Pham
>
>
>
>____________________________________________________________
>Smart Girls Secret Weapon
>Read Unbiased Beauty Product Reviews, Get Helpful Tips, Tricks and Sam
>http://thirdpartyoffers.netzero.net/TGL2231/fc/JKFkuJO6p0CbY0Asyv9Kgbvu8rDzytNh1VTVc9O0q0UJIANGs4M7II/
>
>-------------------------------------------------------------------------
>This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>Build the coolest Linux based applications with Moblin SDK & win great prizes
>Grand prize is a trip for two to an Open Source event anywhere in the world
>http://moblin-contest.org/redirect.php?banner_id=100&url=/
>_______________________________________________
>BitPim-devel mailing list
>[email protected]
>https://lists.sourceforge.net/lists/listinfo/bitpim-devel
>
>

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

_______________________________________________
BitPim-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bitpim-devel

Index: src/phones/com_brew.py
===================================================================
--- src/phones/com_brew.py	(revision 4635)
+++ src/phones/com_brew.py	(working copy)
@@ -1052,9 +1052,11 @@
                     direntry=dir+"/"+res.entryname
                 else:
                     direntry=res.entryname
-                if files and res.type==0: # file or special file
-                    results[direntry]={ 'name': direntry, 'type': 'file',
-                                    'size': res.size }
+                if files and (res.type==0 or res.type == 0x0f): # file or special file
+                    if res.type == 0:
+                        results[direntry]={ 'name': direntry, 'type': 'file', 'size': res.size, 'special': False }
+                    elif res.type == 0x0f:
+                        results[direntry]={ 'name': direntry, 'type': 'file', 'size': res.size, 'special': True }
                     try:
                         if res.date<=0:
                             results[direntry]['date']=(0, "")
@@ -1062,7 +1064,7 @@
                             results[direntry]['date']=(res.date, time.strftime("%x %X", time.localtime(res.date)))
                     except:
                         results[direntry]['date']=(0, "")
-                elif directories and res.type: # directory
+                elif directories and (res.type and res.type != 0x0f): # directory
                     results[direntry]={ 'name': direntry, 'type': 'directory' }
                     if recurse>0:
                         dirs[count]=direntry