please modernize udev rules to consult ATTR{}, not SYSFS{}

[email protected] (Aaron M. Ucko) Thu, 03 Dec 2009 23:29:18 -0500
Newsgroups gmane.comp.mobile.bitpim.devel
Message-ID <[email protected]>
The (generated) udev rules BitPim deploys on Linux use the SYSFS{...}
construct to match relevant USB IDs.  However, that keyword has been
deprecated for some time, and udev 148 now logs warnings upon
encountering it; per the below patch to src/package.py, could you please
substitute ATTR (supported since udev 098, released in August 2006)?

Thanks!

Index: package.py
===================================================================
--- package.py	(revision 4768)
+++ package.py	(working copy)
@@ -257,7 +257,7 @@
     return defaults
 
 udevrules_filename='60-bitpim.rules'
-udevrules_line='ACTION=="add", SYSFS{idProduct}=="%04x", SYSFS{idVendor}=="%04x", RUN+="/usr/bin/bpudev $env{DEVNAME} $number $sysfs{devnum}"'
+udevrules_line='ACTION=="add", ATTR{idProduct}=="%04x", ATTR{idVendor}=="%04x", RUN+="/usr/bin/bpudev $env{DEVNAME} $number $sysfs{devnum}"'
 from common import importas
 def generate_udevrules():
     """Generate the udev rules file based on all the known VIDs and PIDs"""

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
Finger [email protected] (NOT a valid e-mail address) for more info.

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev