Re: SMPP implementation in current CVS build

Illogical and strange but thanks for looking at it (and the fix).

We don't check for host as a default config value either so you get an 
octstr error if you don't specify it. Quick diff fix for that.

# cvs diff -u gw/smsc_smpp.c
Index: gw/smsc_smpp.c
===================================================================
RCS file: /home/cvs/gateway/gw/smsc_smpp.c,v
retrieving revision 1.50
diff -u -r1.50 smsc_smpp.c
--- gw/smsc_smpp.c      2002/01/28 15:12:13     1.50
+++ gw/smsc_smpp.c      2002/01/29 10:27:57
@@ -829,6 +827,10 @@

     /* Check that config is OK */
     ok = 1;
+    if (host == NULL) {
+        error(0,"SMPP: Configuration file doesn't specify host");
+        ok = 0;
+    }
     if (username == NULL) {
        error(0, "SMPP: Configuration file doesn't specify username.");
        ok = 0;
#

Alex

On Tue, 29 Jan 2002, Stipe Tolj wrote:

> > I was able to reproduce this problem on my Solaris 8 box. I then made
> > a wrapper around mutex_lock (created mutex_lock_real adding __FILE__
> > and __LINE__ to the call as a macro) and print out the line and file
> > position of the mutex lock. This made the error go away. Its
> > completely illogical to me but it fixed it. its in CVS right now.
> 
> yep, that's strange.
> 
> I just reviewed the change and it seems the logic is the same. Hmmm..
> 
> Stipe