Re: smsbox_req_sendota broken?

Angel Fradejas wrote:
> 
> No testing at all, just rushing through the code to add support for
> the conig directives I'm working on but I'd say this function is
> broken.

shouldn't be borken, AFAIK.
> 
> We have no initialization for Msg* msg, no msg_create at all.

Ok, now I remember, I have been working on this.

smsbox_req_sendota() calls 
 
    if (ota_type)
        msg = ota_tokenize_settings(grp, from, phonenumber);
    else
        msg = ota_tokenize_bookmarks(grp, from, phonenumber);
 
and those are implemented in gw/ota_prov.c.

So the msg_create is called inside ota_tokenize_foo().

I would hardly wonder that I would commit something like this without
testing if both config OTAs and bookmark OTAs work. 

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are