RE: smsbox_req_sendota broken?

I see the point Stipe, thanks for your response. But before calling
ota_tokenize_xxxx we have all this

    smsc = http_cgi_variable(list, "smsc");
    if (urltrans_forced_smsc(t)) {
        msg->sms.smsc_id = octstr_duplicate(urltrans_forced_smsc(t));
        if (smsc)
            info(0, "send-sms request smsc id ignored, as smsc id forced to
%s",
                 octstr_get_cstr(urltrans_forced_smsc(t)));
    } else if (smsc) {
        msg->sms.smsc_id = octstr_duplicate(smsc);
    } else if (urltrans_default_smsc(t)) {
        msg->sms.smsc_id = octstr_duplicate(urltrans_default_smsc(t));
    } else
        msg->sms.smsc_id = NULL;

That's why I said the function was broken. Take a look again please and
correct me if I'm wrong.

Angel Fradejas.



-----Mensaje original-----
De: [email protected] [mailto:[email protected]]En
nombre de Stipe Tolj
Enviado el: jueves 14 de febrero de 2002 15:47
Para: Angel Fradejas
CC: Kannel Developers
Asunto: Re: smsbox_req_sendota broken?


Angel Fradejas wrote:
>
> No testing at all, just rushing through the code to add support for
> the conig directives I'm working on but I'd say this function is
> broken.

shouldn't be borken, AFAIK.
>
> We have no initialization for Msg* msg, no msg_create at all.

Ok, now I remember, I have been working on this.

smsbox_req_sendota() calls

    if (ota_type)
        msg = ota_tokenize_settings(grp, from, phonenumber);
    else
        msg = ota_tokenize_bookmarks(grp, from, phonenumber);

and those are implemented in gw/ota_prov.c.

So the msg_create is called inside ota_tokenize_foo().

I would hardly wonder that I would commit something like this without
testing if both config OTAs and bookmark OTAs work.

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are