Re: smsbox_req_sendota broken?

Angel Fradejas wrote:
> 
> I see the point Stipe, thanks for your response. But before calling
> ota_tokenize_xxxx we have all this
> 
>     smsc = http_cgi_variable(list, "smsc");
>     if (urltrans_forced_smsc(t)) {
>         msg->sms.smsc_id = octstr_duplicate(urltrans_forced_smsc(t));
>         if (smsc)
>             info(0, "send-sms request smsc id ignored, as smsc id forced to
> %s",
>                  octstr_get_cstr(urltrans_forced_smsc(t)));
>     } else if (smsc) {
>         msg->sms.smsc_id = octstr_duplicate(smsc);
>     } else if (urltrans_default_smsc(t)) {
>         msg->sms.smsc_id = octstr_duplicate(urltrans_default_smsc(t));
>     } else
>         msg->sms.smsc_id = NULL;
> 
> That's why I said the function was broken. Take a look again please and
> correct me if I'm wrong.

yep, you are right. It seems I copied the urltrans_forced_smsc() issue
over into this without noticing that we end up in a messed and non
create msg structure :(((

This is definitly a bug!

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are