Re: I minor error found in gw/smsc_at2.c

Stipe Tolj <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Organization Wapme Systems AG
Message-ID <[email protected]>
"Nektarios K. Papadopoulos" wrote:
> 
> I am using smsc_at with a NOKIA Premicell.
> 
> Thoughth to give a try on smsc_at2. What I was getting was something
> like:
> 
> 2002-02-20 01:20:24 [6] DEBUG: AT2[/dev/ttyS1]: <-- +CSMS: (0)
> 2002-02-20 01:20:24 [6] DEBUG: AT2[/dev/ttyS1]: <-- OK
> 2002-02-20 01:20:24 [6] INFO: AT2[/dev/ttyS1]: Phase 2+ is supported
> 2002-02-20 01:20:24 [6] DEBUG: AT2[/dev/ttyS1]: --> AT+CSMS=1^M
> 2002-02-20 01:20:24 [6] DEBUG: AT2[/dev/ttyS1]: <-- ERROR
> 
> I looke my AT command reference and the code and think that I should not
> get
> 
> Phase 2+ is supported
> 
> I think that passing octstr_case_compare to list_search, makes it to
> search for at least one non matching list element, insteat for one
> matching.
> So I suggest changing it to octstr_item_match, since we care only for
> digits.
> 
> the diff with todays cvs is attached, in case I am not wrong.

any votes from the others, please?!

Putting this at least to STATUS for now.

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.