Re: [PATCH] +CPIN: READY response parsed as time out

Oh. Please please...

Just wait some more days. It's been some complicated days with lots of work.

Things to do:
- Re-check the at_send_command function
- check some really generic at commands to enable kannel to work with every
mobile (at least to send messages) or add at-commands to configuration file
(modemtype=manual, initstring=ATZ;AT+CNMI=1,0,0,0)
- read 3gpp 27005
- Commit the sms-center at patch and some other tweaks waiting in my disk
- Check why smsbox crashes again with empty text
- check some VERY interesting bits in 3gpp/23040 documentation (you'll all
gonna like it)
- convince my T68 to work with kannel
- some more issues I've seen quickly in latest messages
- implement new smsc_pigeons.c (now that we have a framework to Delivery
Reports, we
can finnaly get back our sent pigeons) (i'm kidding)

----- Original Message -----
From: "Oded Arbel" <[email protected]>
To: "Kannel-devel (E-mail)" <[email protected]>
Cc: "Bruno David Rodrigues" <[email protected]>
Sent: Tuesday, February 26, 2002 11:48 AM
Subject: [PATCH] +CPIN: READY response parsed as time out


> -----Original Message-----
> From: kannel [mailto:[email protected]]
> Subject: Daily patch: gateway
>
> +2002-02-25  Bruno Rodrigues  <[email protected]>
> +    * gw/smsc_at2.c: Changed a possible bug. On timeout,
> at2_wait_modem_command
> +      returned -10, and every other line shows that it should be -1;

after that patch, kannel stopped working for me (with wavecom modem).
apparently after it recieved the +CPIN:READY response it concluded that
the device cannot be opened and shut the module down.

tracking it down :
this code in init_device()
        ret = at2_send_modem_command(privdata, "AT+CPIN?", 0, 0);
        if(ret == -1)
    return -1;
breaks out if timeout occured after the CPIN command.
this code in wait_modem_command :
           if (-1 != octstr_search(line, octstr_imm("+CPIN: READY"), 0))
           {
           privdata->pin_ready = 1;
continue;
   }
will cause Kannel to return with a time out for a +CPIN: READY response
(no OK sent after that), and return -10 before the patch, which is ok
with init_device. after the patch it will return -1 and so it will break
init_device.

attacehd it a patch that fixed the problem for me (I am going to attach
it, this time :-)

Cheers

Oded Arbel
m-Wise Inc.
[email protected]

--
A committee takes root and grows, it flowers, wilts and dies, scattering
the seed from which other committees will bloom.
-- Parkinson