RE: Delivery Report crash Kannel
"Angel Fradejas" <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
>>> I have problem with kannel CVS regarding SMPP. >>> Thsi problem occured when I activate dlrmask in http request >>> >>>http://localhost:xxxx/cgi-bin/sendsms?username=xxxr&password=xxx&to=62818 155112&mclass=1&text=hallo&dlrmask=1 >>> >>> The message seem delivered. But after that kannel crashed with >>> error: >>> 2002-02-28 07:08:05 [5] PANIC: gwlib/octstr.c:2053: >>> seems_valid_real: Assertion `ostr != NULL' failed. (Called from >>> gw/smsc_smpp.c:572:handle_pdu.) >> >>Andreas, this seems to break something in the dlr_add() call. Any >>ideas from you why we are throwing assertion error here? >> > > >this is octstr_get_cstr(msg->sms.receiver), > >so apparently somehow the receiver of the SMS is not set in the PDU. >This is invalid and has nothing to do with DLR. I agree this is invalid, sure. But we cannot say "this is invalid" and nothing more. The point is that *real* SMSC's may be sending stuff like that, and Kannel cannot just stop. Just imagine if the Apache team would say that with and misformed GET request por example. Kannel must do its best to never quit. Just ignore misformed PDUs with a warning, that's ok! But not quit please. I'm taking the oportunity to speak more generally, not just for this actual failed assertion. Just my 2 cents. Angel Fradejas.