Bug in sms_split() ?

"Paul Keogh" <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <[email protected]>
I've a problem when I send a 160 character message (7BIT coding)
to an M20 - the M20 fails with a CMS 304 because the charset_latin1_to_gsm()
function *increases* the size of the message to 163 characters due to
GSM code escaping.

I think sms_split() should figure this in for the SMS box. If you insert the
lines;

    list = list_create();
+
+	if (octstr_len (temp->sms.msgdata) > max_part_len)
+		max_part_len = max_part_len - (sms_msgdata_len (temp) -
+			octstr_len (temp->sms.msgdata));
+
    do {

you adjust max_part_len accordingly. This is quite coarse as ideally you'd
figure out which part-> contains characters to be expanded and only reduce
its
max_part_len rather than reduce all part->'s.

Comments ?

Paul Keogh
ANAM Wireless Internet Solutions
http://www.anam.com
+353 1 284 7555 (wired)               +353 86 234 6047 (wireless)
Castle Yard, Saint Patrick's Road, Dalkey, County Dublin, Ireland
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.