Bug in wap_push_ppg.c ?

"Paul Keogh" <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Message-ID <[email protected]>
I think the function;

/*
 * Check that we have rigth application id for confirmed push (it is,
"push.sia")
 */
static int coriented_deliverable(long appid_code)
{
    return appid_code == 2;
}

should be

static int coriented_deliverable(long appid_code)
{
    return appid_code == 1;
}

This would then match the wap/wsp_strings definitions of;

NUMBERED(application_id,
ASSIGN("*", 0x00)
ASSIGN("push.sia", 0x01)
ASSIGN("wml.ua", 0x02)
ASSIGN("wta.ua", 0x03)
ASSIGN("mms.ua", 0x04)
ASSIGN("push.syncml", 0x05)
ASSIGN("loc.ua", 0x06)
)

Right ?

Paul Keogh
ANAM Wireless Internet Solutions
http://www.anam.com
+353 1 284 7555 (wired)               +353 86 234 6047 (wireless)
Castle Yard, Saint Patrick's Road, Dalkey, County Dublin, Ireland
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.