Re: combined patch SMPP things

At 01:01 PM 5/6/02 +0200, Stipe Tolj wrote:
>Benjamin Lee schrieb:
>
>looks good for me, +1 for commitment, any other opinions?


yeah +1 for me.. except that the generic nack can be  used by the SMSC for 
ESME_RTHROTTLED. I have the following for generic_nack_resp

case generic_nack_resp:
         {
                         error(0, "SMPP: NACK PDU type 0x%08lx, "
                                 "code 0x%08lx.",
                         pdu->type, pdu->u.generic_nack_resp.command_status);


                         if (pdu->u.generic_nack_resp.command_status == 
0x58) //ESME_RTHROTTLED
                         {
                                 warning(0, "SMPP: nack: %s 
ESME_RTHROTTLED. Re re queuing",octstr_get_cstr(smpp->conn->name));
                         reason = smpp_status_to_smscconn_failure_reason(
                                                         pdu->u.submit_sm.command_status);
                         bb_smscconn_send_failed(smpp->conn, msg, reason);
                          --(*pending_submits);
                         }

         }
     break;



nisan

>Stipe
>
>[email protected]
>-------------------------------------------------------------------
>Wapme Systems AG
>
>Münsterstr. 248
>40470 Düsseldorf
>
>Tel: +49-211-74845-0
>Fax: +49-211-74845-299
>
>E-Mail: [email protected]
>Internet: http://www.wapme-systems.de
>-------------------------------------------------------------------
>wapme.net - wherever you are