Re: [PATCH] counter type change
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | Wapme Systems AG |
| Message-ID | <[email protected]> |
Harrie Hazewinkel wrote: > > I have attached a patch for the kannel code which make the > internal type of the counter object an 'unsigned long'. > The advantage is that it wraps by itself and we have 1 bit > more in the value of the counter (32 bits). :-)) > > I noticed also that sometimes the value of the counter > returned by the accessor-functions used already 'unsigned > long'. > > I have also added a 'counter_increase_with' value for > usage to increase counters by more then 1. This is when > one would count for instance the total bytes of the > messages sent. > > Besdies I have a question; why is in most cases the > counter value retrieved and stored elsewhere. > One could directly get the value of the counter > by just keeping the reference to it in those > placed where now this value is 'copied'. patch applied, thanks Harrie! Stipe [email protected] ------------------------------------------------------------------- Wapme Systems AG Münsterstr. 248 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [email protected] Internet: http://www.wapme-systems.de ------------------------------------------------------------------- wapme.net - wherever you are