RE: More Info: Problem with EMI2, latest cvs

Hi Bruno,
i've sent the patch to list 2 weeks ago and still have not any comments.
May be you can look at it?

cheers,
Dima.

-----Original Message-----
From: Dima Milentiev 
Sent: Thursday, May 09, 2002 2:21 PM
To: Bruno David Simoes Rodrigues
Cc: [email protected]
Subject: RE: More Info: Problem with EMI2, latest cvs


Hi,
here is a patch.		

-----Original Message-----
From: Bruno David Simoes Rodrigues [mailto:[email protected]]
Sent: Sunday, May 05, 2002 5:36 PM
To: Dima Milentiev
Cc: Abd Rahman Johari; [email protected]
Subject: RE: More Info: Problem with EMI2, latest cvs


On Sun, 2002-05-05 at 07:23, Dima Milentiev wrote:
> Hi,
> 
> I think you've a problem with octstr_get_cstr(conn->id) if 'smsc_id'
> parameter is not defined in kannel.conf
> 
> 		msg = dlr_find(octstr_get_cstr(conn->id), 
> 			octstr_get_cstr(emimsg->fields[E50_SCTS]), /*
> timestamp */
> 			octstr_get_cstr(emimsg->fields[E50_OADC]), /*
> destination */
> 			DLR_SUCCESS);
> 
> I passed from 1.1.4 to 1.1.6 CVS for SMPP last Thursday and got the
same
> error.  It's work when smsc_id is defined.
> I think we have a little bug here. If we use MySQL option we need to
> check smsc_id configuration parameter and notify the system as usual
> (panic) or use some defaullt with warning.

I've already patched this in emi2.

Basically, what I've done is that privdata->name is always filled, with
name field in config or with "ip:port", so I'm using conn->id if set 
else privdata->name

In smpp, you (or I, if noone else does it) can use privdata->name too, 
but check if it is filled with something if it is empty in config


> 
> regards,
> 
> Dima Milentiev
> m-Wise Mobile Solutions
> 
> [email protected]
> Mobile: +972 (55) 679229
> Tel:    +972 (9)  9581711 (ext: 120)
> 
>  
> 
> -----Original Message-----
> From: Abd Rahman Johari [mailto:[email protected]]
> Sent: Friday, May 03, 2002 2:22 AM
> To: [email protected]
> Subject: More Info: Problem with EMI2, latest cvs
> 
> 
> more info regarding this issue, if the SMSC doesn't send any message,
> the
> kannel was okay and i can send out sms,
> but if the kannel starts to receive message from SMSC, it will just
die
> with
> the following error, i wonder what has happened here,
> since i have just got into this kind of problem couple days ago. I've
> tested
> with early release of kannel and all of them face the same problem.
> 
> regards,
> -man-
> ----- Original Message -----
> From: "Abd Rahman Johari" <[email protected]>
> To: <[email protected]>
> Sent: Wednesday, May 01, 2002 9:56 AM
> Subject: Problem with EMI2, latest cvs
> 
> 
> > Hi,
> > i got this from latest kannel cvs, i'm using EMI2 protocol
> > this is using UCP60 (outgoing sms)
> >
> > 2002-05-01 09:45:50 [0] ERROR: Can't find out official hostname for
> this
> > host, using `gateway.celcom' instead.
> > 2002-05-01 09:45:50 [0] INFO: Debug_lvl = -1, log_file = <none>,
> log_lvl =
> 0
> > 2002-05-01 09:45:50 [0] WARNING: DLR: using default 'internal' for
> storage
> > type.
> > 2002-05-01 09:45:50 [0] DEBUG: Kannel bearerbox version `cvs'.
> > System Linux, release 2.4.9-21, version #1 Thu Jan 17 14:16:30 EST
> 2002,
> > machine i686.
> > Hostname gateway.celcom, IP 127.0.0.1.
> > Libxml version 20417.
> > Using OpenSSL 0.9.6b [engine] 9 Jul 2001.
> > Using checking malloc.
> >
> > 2002-05-01 09:45:50 [0] INFO: Added logfile `logs/free-core-log.log'
> with
> > level `0'.
> > 2002-05-01 09:45:50 [0] INFO:
----------------------------------------
> > 2002-05-01 09:45:50 [0] INFO: Kannel bearerbox II version cvs
starting
> > 2002-05-01 09:45:50 [0] INFO: Started access logfile
> > `logs/free-core-access.log'.
> > 2002-05-01 09:45:50 [0] DEBUG: HTTP: Opening server at port 15000.
> > 2002-05-01 09:45:50 [0] DEBUG: Started thread 1
(gwlib/fdset.c:poller)
> > 2002-05-01 09:45:50 [0] DEBUG: Started thread 2
> (gwlib/http.c:server_thread)
> > 2002-05-01 09:45:50 [0] DEBUG: Started thread 3
> (gw/bb_http.c:httpadmin_run)
> > 2002-05-01 09:45:50 [0] DEBUG: starting smsbox connection module
> > 2002-05-01 09:45:50 [0] DEBUG: Started thread 4
> (gw/bb_boxc.c:smsboxc_run)
> > 2002-05-01 09:45:50 [0] DEBUG: Started thread 5
> > (gw/smsc_emi2.c:emi2_listener)
> > 2002-05-01 09:45:50 [0] DEBUG: Started thread 6
> (gw/smsc_emi2.c:emi2_sender)
> > 2002-05-01 09:45:50 [6] INFO: EMI2[10.122.25.88:5115]: connecting to
> Primary
> > SMSC
> > 2002-05-01 09:45:50 [0] DEBUG: Started thread 7
> > (gw/bb_smscconn.c:sms_router)
> > 2002-05-01 09:45:50 [0] INFO: MAIN: Start-up done, entering mainloop
> > 2002-05-01 09:45:50 [0] DEBUG: EMI2[10.122.25.88:5115]: start called
> > 2002-05-01 09:45:50 [7] DEBUG: sms_router: time to sleep
> > 2002-05-01 09:45:50 [7] DEBUG: sms_router: list_len = 0
> > 2002-05-01 09:45:50 [6] DEBUG: EMI2[10.122.25.88:5115]: Sending
> operation
> > type 60, message with password not shown in log file.
> > 2002-05-01 09:45:50 [6] DEBUG: EMI2[10.122.25.88:5115]: emi2 parsing
> packet:
> > <00/00019/R/60/A//6D>
> > 2002-05-01 09:45:50 [6] DEBUG: EMI2[10.122.25.88:5115]: emi2 sending
> packet:
> > <00/00027/O/31/40000/0539/EB>
> > 2002-05-01 09:45:50 [6] DEBUG: EMI2[10.122.25.88:5115]: Got packet
> from
> the
> > main socket
> > 2002-05-01 09:45:50 [6] DEBUG: EMI2[10.122.25.88:5115]: emi2 parsing
> packet:
> >
>
<00/00297/O/53/40000/0193514638/////////////010502094653/0/000/010502094
> 655/
> >
>
3//4D65737361676520666F7220303139333531343633382C2077697468206964656E746
> 9666
> >
>
9636174696F6E2030323035303130393436353320686173206265656E2064656C6976657
> 2656
> >
>
4206F6E20323030322D30352D30312061742030393A34363A35352E/////////////F7>
> > 2002-05-01 09:45:50 [6] PANIC: gwlib/octstr.c:2098:
seems_valid_real:
> > Assertion `ostr != NULL' failed. (Called from
> > gw/smsc_emi2.c:686:handle_operation.)
> >
> > below i'm using UCP52 (incoming sms)
> > 2002-05-01 09:50:42 [6] WARNING: EMI2[10.10.10.8:5002]: Unsupported
> EMI
> XSer
> > field 13
> > 2002-05-01 09:50:42 [4] INFO: Starting to service <HELP> from
> <+6019XXXXXX>
> > to <99988>
> >
> > Regards,
> > -man-
> >
> >
> >
> 
> 
>

--- gateway/gw/smsc_smpp.c	2002-05-05 10:57:31.000000000 +0300
+++ gateway/gw/smsc_smpp.c	2002-05-09 13:28:52.000000000 +0300
@@ -902,7 +924,7 @@
     SMPP *smpp;
     int ok;
     int transceiver_mode;
-
+    Octstr *smsc_id;
     
     my_number = NULL;
     transceiver_mode = 0;
@@ -969,6 +991,11 @@
 			       (receive_port ? receive_port : port), 
 			       username, system_type);
 
+    smsc_id = cfg_get(grp, octstr_imm("smsc-id"));
+        if (smsc_id == NULL) {
+	    conn->id = octstr_duplicate(conn->name);
+	}
+	
     octstr_destroy(host);
     octstr_destroy(username);
     octstr_destroy(password);
@@ -976,7 +1003,8 @@
     octstr_destroy(address_range);
     octstr_destroy(our_host);
     octstr_destroy(my_number);
-
+    octstr_destroy(smsc_id);
+    
     conn->status = SMSCCONN_CONNECTING;
       
     /*