Re: recent SMPP patches.

Hi list.

We updated to the CVS today and tried to merge the changes, and didn't
like a few things, so here they are in no significant order :

* smsc_id - if NULL, it duplicates the conn->name, but it does so before
conn->name is created. not nice :-)
* destruction of relation_UTC_time in msg_to_pdu() - checking if it is
null isn't needed, since octstr_destroy checks for it to be !NULL
before destroying it.
* in computing relation_UTC_time, the logic assumes that all time zones
have differences of 1 hour to one another, which is not correct - there
are some timezones that have a difference of half an hour.

Thanks

--
Oded Arbel
m-Wise Inc.
[email protected]
(972)-67-340014
(972)-9-9581711 (ext: 116)

::..
After a number of decimal places, nobody gives a damn.