Re: recent SMPP patches.
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | Wapme Systems AG |
| Message-ID | <[email protected]> |
Oded Arbel wrote: > > * smsc_id - if NULL, it duplicates the conn->name, but it does so before > conn->name is created. not nice :-) could you provide a quick patch for how you mean it would be looking better, please? > * destruction of relation_UTC_time in msg_to_pdu() - checking if it is > null isn't needed, since octstr_destroy checks for it to be !NULL > before destroying it. yep, you're right. I added both declarative initialization and the NULL checking, which is done inside octstr_destroy() itself. Removing this. > * in computing relation_UTC_time, the logic assumes that all time zones > have differences of 1 hour to one another, which is not correct - there > are some timezones that have a difference of half an hour. ups, Alan, can you provide a fix for this? Stipe [email protected] ------------------------------------------------------------------- Wapme Systems AG Münsterstr. 248 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [email protected] Internet: http://www.wapme-systems.de ------------------------------------------------------------------- wapme.net - wherever you are