RE: recent SMPP patches.
"Oded Arbel" <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
> -----Original Message----- > From: Stipe Tolj [mailto:[email protected]] > Sent: Wednesday, May 22, 2002 1:59 PM > To: Oded Arbel > Cc: Kannel-devel (E-mail); Alan McNatty > Subject: Re: recent SMPP patches. > > > Oded Arbel wrote: > > > > * smsc_id - if NULL, it duplicates the conn->name, but it > does so before > > conn->name is created. not nice :-) > > could you provide a quick patch for how you mean it would be looking > better, please? How about this ? -- Oded Arbel m-Wise Inc. [email protected] (972)-67-340014 (972)-9-9581711 (ext: 116) ::.. "Things should be made as simple as possible but not simpler." --Albert Einstein
smpp.patch
(application/octet-stream, 841 B)
--- kannel-dev/gateway/gw/smsc_smpp.c 2002-05-22 11:40:16.000000000 +0300
+++ gateway/gw/smsc_smpp.c 2002-05-22 14:50:26.000000000 +0300
@@ -1053,10 +1053,6 @@
max_pending_submits, reconnect_delay,
version, my_number);
- smsc_id = cfg_get(grp, octstr_imm("smsc-id"));
- if (smsc_id == NULL) {
- conn->id = octstr_duplicate(conn->name);
- }
conn->data = smpp;
conn->name = octstr_format("SMPP:%S:%d/%d:%S:%S",
@@ -1064,6 +1060,11 @@
(receive_port ? receive_port : port),
username, system_type);
+ smsc_id = cfg_get(grp, octstr_imm("smsc-id"));
+ if (smsc_id == NULL) {
+ conn->id = octstr_duplicate(conn->name);
+ }
+
octstr_destroy(host);
octstr_destroy(username);
octstr_destroy(password);