RE: EMI2 Panic

yes - since the octstr is used only as an argument to format in which it is copied, then using octstr_create() to emulate NULL will create a memory leak. use octstr_imm() instead.

--
Oded Arbel
m-Wise mobile solutions
[email protected]

+972-9-9581711
+972-67-340014

::..
Artificial Intelligence:  Making computers behave like they do in the movies.




> -----Original Message-----
> From: Stipe Tolj [mailto:[email protected]]
> Sent: Thursday, June 27, 2002 3:01 PM
> To: Andreas Fink
> Cc: [email protected]
> Subject: Re: EMI2 Panic
> 
> 
> The following patch should fix the NULLed variable addressing:
> 
> RCS file: /home/cvs/gateway/gw/smsc_emi2.c,v
> retrieving revision 1.56
> diff -r1.56 smsc_emi2.c
> 1617c1617
> <                                privdata->username);
> ---
> >                                privdata->username ? 
> privdata->username : octstr_create("<null>"));
> 
> 
> any objections out there to commit this fix?!
> 
> Stipe
> 
> [email protected]
> -------------------------------------------------------------------
> Wapme Systems AG
> 
> Vogelsanger Weg 80
> 40470 Düsseldorf
> 
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
> 
> E-Mail: [email protected]
> Internet: http://www.wapme-systems.de
> -------------------------------------------------------------------
> wapme.net - wherever you are
> 
>