Re: Problem with SMPP smsc-password being too long

Kaido Karner wrote:
> 
> > 2002-07-05 20:51:43 [0] INFO: MAIN: Start-up done, entering mainloop
> > 2002-07-05 20:51:43 [8] DEBUG: sms_router: time to sleep
> > 2002-07-05 20:51:43 [8] DEBUG: sms_router: list_len = 0
> > 2002-07-05 20:51:43 [6] PANIC: gw/smpp_pdu.def:60: smpp_pdu_pack:
> > Assertion
> > `octstr_len(p->password) < 9' failed.
> 
> re ...
> 
> I understand that the password being longer is not allowed, but closeing
> with panic is not bad idea on simple configuration mistake. should not it be
> a warning/error, but to allow to continue? the same about all other similar
> checks - quitting with panic if even a part of the system can run, is not a
> good idea. and note if somebody will take a time and re-code kannel so that
> smsc connections can be reconfigured and added on-line, such a practice is
> not acceptable anyway ...

contiue? why? the password is logically longer than 8 octects, but the
SMPP spec does not accept it to put it in the appropriate PDUs. So
what should you do then? Cut the Password to 8 chars long and send the
login sequence anyway? No, I don't think so.

The assertion check fails, and a failing assertion check means a non
recoverable state within the system, hence panic! This is my opinion
about the functional logic.

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are