Re: Problem with SMPP smsc-password being too long
Oded Arbel <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Kaido Karner wrote: >>2002-07-05 20:51:43 [0] INFO: MAIN: Start-up done, entering mainloop >>2002-07-05 20:51:43 [8] DEBUG: sms_router: time to sleep >>2002-07-05 20:51:43 [8] DEBUG: sms_router: list_len = 0 >>2002-07-05 20:51:43 [6] PANIC: gw/smpp_pdu.def:60: smpp_pdu_pack: >>Assertion >>`octstr_len(p->password) < 9' failed. >> >> > > >re ... > >I understand that the password being longer is not allowed, but closeing >with panic is not bad idea on simple configuration mistake. should not it be >a warning/error, but to allow to continue? the same about all other similar >checks - quitting with panic if even a part of the system can run, is not a >good idea. and note if somebody will take a time and re-code kannel so that >smsc connections can be reconfigured and added on-line, such a practice is >not acceptable anyway ... > > > You are right - the module should simply terminate with an error and not a panic, the way that other modules are doing when encountering a configuration error. -- Oded Arbel m-Wise mobile solutions