Re: [patch] Tariff support & configure (libxml2)

Marko Saaresto wrote:

> @@ -1809,7 +1833,13 @@
>         goto fielderror;
>      }
>      msg->sms.alt_dcs = alt_dcs;
> -
> +
> +    if ( tariff < 0 || alt_dcs > 99 ) {
> +       returnerror = octstr_create("Tariff field misformed, rejected");
> +       goto fielderror;
> +    }
> +    msg->sms.tariff = tariff;
> +
>      if ( mwi < 0 || mwi > 8 ) {
>         returnerror = octstr_create("MWI field misformed, rejected");
>         goto fielderror;

In this chunk there is obviously a typo in the if statement, or are
you really comparing tariff with alt_dcs :))

For the changes in gw/smsc_cimd2.c I'd like to see comment lines in /*
foobar comment */ instead of // foobar, please. Isn't this defined in
doc/CodingStyle?!

Please fix the above issue and resubmit the patch to the list.

Any votes for adding the tariff class supports to smsc_cimd2 and
smsc_http?

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are