RE: [PATCH] SMPP panic when sender or receiver address longer then20 characters.

--On Sunday, August 11, 2002 2:46 PM +0300 Oded Arbel <[email protected]> 
wrote:

>
>> -----Original Message-----
>> From: Oded Arbel
>> > in some #define and use that?? Then changing the length is
>> > done in one place
>> > only.
>>
>> it is - in the smpp_pdu.def :
>
> hm. my bad - this is not what you meant. doing as you suggested is more
> correct, but currently that number is only used in two lines of code (one
> right after the other) and I can't see how we can extract if from the
> pdu.def, so using it in a define has the single advantage of moving the
> defining point from halfway down the file to the top of the file (or to
> the header).

I admit these .def files are difficult, but I believe we need to make
a define and use that define +1 in the .def file to allcate the space
and use the define itself in the other places.


Harrie

Internet Management Consulting
mailto:[email protected]                http ://www.mod-snmp.com/
-------------------------------------------------------------------
Author of MOD-SNMP, enabling SNMP management to the Apache server.