RE: [PATCH] SMPP octstr to long handling
"Oded Arbel" <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
> -----Original Message----- > From: Stipe Tolj [mailto:[email protected]] > I'd suggest not to copy at the place Oded does, but in > smpp_pdu.c:smpp_pdu_pack() by taking out the assertion check and > throwing an error to the log and copy the Octstrs to the desired > length, please see patch attached. > > Votes for this solution in favour of Odeds? Yes - your solution is better. I'd vote +1 on Stipe's and removing my patch. btw - what happened to unified diff format ? -- Oded Arbel m-Wise mobile solutions [email protected] +972-9-9581711 (116) +972-67-340014 ::.. You cannot propel yourself forward by patting yourself on the back.