Re: [BUG] SMPP setting esm_class
Stipe Tolj <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Organization | Wapme Systems AG |
| Message-ID | <[email protected]> |
> following bug in SMPP code in msg_to_pdu: > > /* > * set the esm_class field > * default is store and forward, plus udh and rpi if requested > */ > pdu->u.submit_sm.esm_class = ESM_CLASS_STORE_AND_FORWARD_MODE; > if (octstr_len(msg->sms.udhdata)) > pdu->u.submit_sm.esm_class = pdu->u.submit_sm.esm_class & > ESM_CLASS_UDH_INDICATOR; > if (msg->sms.rpi) > pdu->u.submit_sm.esm_class = pdu->u.submit_sm.esm_class & > ESM_CLASS_RPI; > > surely this should be > ...... > pdu->u.submit_sm.esm_class = pdu->u.submit_sm.esm_class | > ESM_CLASS_UDH_INDICATOR; > ..... > pdu->u.submit_sm.esm_class = pdu->u.submit_sm.esm_class | > ESM_CLASS_RPI; yep, obviously I typo'ed here in bit calculus, this by the way broke UDH based transmissions for the SMPP module, sorry guys. Patch commited to cvs. Stipe [email protected] ------------------------------------------------------------------- Wapme Systems AG Vogelsanger Weg 80 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [email protected] Internet: http://www.wapme-systems.de ------------------------------------------------------------------- wapme.net - wherever you are