Re: Kannel automatic compilation test

--On Wednesday, September 4, 2002 10:10 AM +0200 Stipe Tolj 
<[email protected]> wrote:

>> Stipe,
>>
>> Would this patch solve it. Not knowing the protocol spec of SMASI.
>
> I can try. But I took the code from smsc_smpp.c as template and AFAIK,
> they had no such mungy p = *(&p); thingies :))

I came up with this, since it is already in some places of the SMASI
code. Since I believe you wanted a NO-OP function, but this is
mainly an attempt to read your mind.

>
> Stipe
>
>
> Harrie Hazewinkel schrieb:
>>
>> Stipe,
>>
>> Would this patch solve it. Not knowing the protocol spec of SMASI.
>>
>> Index: smasi_pdu.c
>> ===================================================================
>> RCS file: /home/cvs/gateway/gw/smsc/smasi_pdu.c,v
>> retrieving revision 1.2
>> diff -u -r1.2 smasi_pdu.c
>> --- smasi_pdu.c 19 Aug 2002 09:15:16 -0000      1.2
>> +++ smasi_pdu.c 3 Sep 2002 12:16:21 -0000
>> @@ -140,7 +140,7 @@
>>      }
>>
>>      switch (pdu->type) {
>> -    #define NONTERMINATED(name)
>> +    #define NONTERMINATED(name) p = *(&p);
>>      # define COMATERMINATED(name) \
>>      if (p->name != NULL) { octstr_append_cstr(os, #name); \
>>      octstr_append_char(os, '='); \
>> @@ -177,8 +177,8 @@
>>      type_name = (temp ? octstr_get_cstr(temp) : "");
>>
>>      if (strcmp(type_name, "dummy") == 0) type = 0;
>> -    #define NONTERMINATED(name)
>> -    #define COMATERMINATED(name)
>> +    #define NONTERMINATED(name) p = *(&p);
>> +    #define COMATERMINATED(name) p = *(&p);
>>      # define PDU(name, id, fields) \
>>      else if (strcmp(type_name, #name) == 0) type = id;
>>      # include "smasi_pdu.def"
>> @@ -191,7 +191,7 @@
>>      skip_until_after_colon(data_without_len, &pos);
>>
>>      switch (type) {
>> -    #define NONTERMINATED(name)
>> +    #define NONTERMINATED(name) p = *(&p);
>>      # define COMATERMINATED(name) \
>>                  if (octstr_str_compare(field_name, #name) == 0 &&
>> field_value != NULL) \
>>                      p->name = octstr_duplicate(field_value);
>> @@ -226,7 +226,7 @@
>>      debug("sms.smasi", 0, "SMASI PDU %p dump:", (void *) pdu);
>>      debug("sms.smasi", 0, "  type_name: %s", pdu->type_name);
>>      switch (pdu->type) {
>> -    #define NONTERMINATED(name)
>> +    #define NONTERMINATED(name) p = *(&p);
>>      # define COMATERMINATED(name) \
>>      octstr_dump_short(p->name, 2, #name);
>>      # define PDU(name, id, fields) \
>>



Harrie

Internet Management Consulting
mailto:[email protected]                http ://www.mod-snmp.com/
-------------------------------------------------------------------
Author of MOD-SNMP, enabling SNMP management to the Apache server.