EMI2 patch for reconnection

I say +1 to this patch. We use emi2 for production and this
problem has been bugging us for ages. Would be nice to have
a proper reconnect mechanism for once.

--michael


From: "Angel Fradejas" <[email protected]>
To: "Kannel Developers" <[email protected]>
Subject: [REPOST] [PATCH] emi2 reconnection behaviour
Date: Fri, 20 Sep 2002 09:59:03 +0200

This is a multi-part message in MIME format.

------=_NextPart_000_001A_01C2608C.59B33580
Content-Type: multipart/alternative;
boundary="----=_NextPart_001_001B_01C2608C.59B33580"


------=_NextPart_001_001B_01C2608C.59B33580
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by int-mail01.mediafusion.es id g8K80Xc00731

Not much feedback on this one... (apart from Oded ;-) Don't you guys thin=
k
this would be a nice fix to have on CVS?

It would be nice to hear from the ones using EMI2 in a production
environment.

Angel.


-----Mensaje original-----
De: [email protected] [mailto:[email protected]]En
nombre de Angel Fradejas
Enviado el: lunes 9 de septiembre de 2002 11:30
Para: Kannel Developers
Asunto: [PATCH] emi2 reconnection behaviour


Hi all,

Attached is a patch to change the current behaviour of EMI2 driver when
handling connection errors.
I'm making EMI2 driver consistent with SMPP and SM/ASI behaviour and
configuration directives, while trying to fix a couple of things.

This is what the patch changes:

1) Removes "retry" smsc config directive for EMI2. It always assumes
reconnection, as the rest of drivers.
2) Adds a "reconnect-delay" directive, as SMPP and SM/ASI drivers: option=
al
time between attemps in seconds. It defaults to 10 seconds.

The reason for this changes (apart from making all drivers consistent), i=
s
that current EMI2 handling of reconnection attempts is a mess.
Let me explain why:

1) It defaults to not retrying reconnection. That means that when you sta=
rt
bearerbox, if a single EMI2 driver fails, the whole bearerbox refuses to
start. This is not acceptable for production use.

2) When it tries a reconnection (other than first time remember), it doub=
les
the time between attempts, until it reaches a fixed value. If you have
retry=3Dyes it will grow until 64 minutes (!!!) and then settles on 60 mi=
nutes
(too much for production use).
Weirdly, if you have retry=3Dno, it will also try to reconnect, but the t=
ime
between attemps grows only until 10 minutes.

Please, let me know comments and votes on this patch.

Thank you all.

Angel Fradejas
Mediafusi=F3n Espa=F1a, S.A.
[email protected]
www.mediafusion.es
Tel. +34 91 252 32 00
Fax  +34 91 572 27 08



---
Outgoing mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.386 / Virus Database: 218 - Release Date: 9/9/2002