Re: CMTI patch - revisited...

Hello devel,

Sorry... To correct myself before anybody else does :)
There was a memory leak in the previous patch when more than 1 CMTI
indication would come in at the same time.

Also, I made an extra check in the sim buffering handling to have sim
buffering and this CMTI patch live next to each other peacefully.

So pls. use attached patch in stead of previous one.

-- Rene...

Saturday, September 21, 2002, 2:53:26 AM, you wrote:

RKCSS> Hello devel,

RKCSS>   Please find attached a CMTI-patch.
RKCSS>   It does not call at2_wait_modem_command recursively.

RKCSS>   The changes are relatively big, compared to my first quick hack (but
RKCSS>   hey, you asked for it ;]).

RKCSS>   I made a seperate queue in the privdata struct and I put CMTI
RKCSS>   notifications in it.
RKCSS>   The queue is emptied again in the main thread.
RKCSS>   The code that reads and deletes a message from memory is put in a
RKCSS>   seperate function (first it was part of the sim-buffering code).

RKCSS>   I read the CodingStyle doc and tried to follow the advice that I got
RKCSS>   in this list. But let me know if you want things to be done
RKCSS>   differently. I am still getting into this project.

RKCSS>   One question though: In the function smscenter_receive_msg() in
RKCSS>   sms.c, all the different kinds of smsc-interfaces are queried for
RKCSS>   pending messages. Only the at2 smsc is not there. Why? Is this
RKCSS>   function depricated and replaced by the bb_smsccon functions?

RKCSS>   Any comments are welcome.





-- 
Best regards,
 Rene                            mailto:[email protected]