Re: [PATCH] Chararcter @ in SMPP

Hi
At 11:43 AM 10/2/02 +0700, you wrote:
>
>
>I d like to propose patch to fix problem with character @ in SMPP.


vote -2 .. no ways ..
the mapping array in Kannel is correct for Latin1 to GSM and back!!.. @ is 
0x00 in GSM charset. Now if you look carefully you will see that there are 
not that many chars that are actually different from Latin1 to GSM, but 
more than just the @. The real issue is that not all SMSCs use the GSM 
charset as the default. Vodacom in SA use ASCII and only ASCII.

Anyone interested in seeing the patch to add other character mappings to 
the charset handling functions in Kannel. We use this to load an ASCII 
mapping table (from a config file) for the one SMPP provider that wants @ 
(and the other few) as its ASCII representation. latin1_to_mapset and 
mapset_to_latin1

Nisan



>Since, I read from kannel userguide.html, the character @ in SMPP has sign 
>y? . It means driver probably has this feature, has not been tested .
>
>Then I tested it. The conclusion is the problem seems still there because 
>kannel mapping @ to I .
>
>
>
>This patch will patch file charset.c (below dir /gwlib). I notice that 
>smsc_smpp.c use character set defined in charset.c file.
>
>I modified character mapping (for @) in charset.c.
>
>I already use this patch since 1.2.0 in CVS (maybe since 1.1.6 don t 
>remember) and it work for me. I used it for my sms to mail and mail to sms 
>services.
>
>
>
>Please take a look on this patch, because I only test it in SMPP environment.
>
>I am afraid this patch affects other driver.
>
>
>
>
>
>Kindly Regards
>
>-dedy-