Re: smpp, ton and npi problem

On Monday 07 October 2002 07:44 pm, Damjan wrote:

> > > PLEASE tell me if I need to explain more throughly what the
> > > problem, I think, is.
> >
> > What defaults did you change in the code, if not the force_* values ?
>
> Here it is, a diff of the changes I made (there are some other
> small changes that are not important).

There are numerous changed lines that are redundant with previous code - for 
example, all the places where you set the NPI to E164 can be safeuly removed, 
i.e. - instead of modifying UNKNOWN to E164 - simply remove the assignment, 
because the default is E164.

So basicly, what you do is to change the default TON to be INTERNATIONAL and 
not assign NPI_UNKNOWN under any condition. from first glance I don't think 
this is correct, as that way you can't send national MSISDNs, and anyway - 
the decision to use national, international or alphanumeric TON should be 
handled by the internal logic - which your patch does not fix (if it indeed 
broken, which I'm still not convinced it is). the change of NPI from Unknown 
to E164 may have some merits - I'll check that.

So - the only difference between your changes and setting force ton/npi is the 
ability of the internal logic to set TON to ALPHANUMERIC if the MSISDN has 
non-digit characters. 

correct me if I'm wrong.

-- 
Oded Arbel
m-Wise mobile solutions