RE: Veto againt last smsc/smsc_smpp.c commit

It will work as long as your SMSC sends you those optional fields. when kannel with those fields will try to parse a PDU that does not contain those fields (they are optional, after all) it will break horribly.

--
Oded Arbel
m-Wise mobile solutions
[email protected]

+972-9-9581711 (116)
+972-67-340014

::..
"if you see an ad for a movie on a grocery-store [divider],
you can be pretty sure it's not a good movie."
	-- M Groening




> -----Original Message-----
> From: David Chkhartishvili [mailto:[email protected]]
> Sent: Wednesday, October 16, 2002 1:49 PM
> To: Oded Arbel
> Cc: Stipe Tolj; Andreas Fink; [email protected]
> Subject: Re: Veto againt last smsc/smsc_smpp.c commit
> 
> 
>  I've already patched kannel. I added fields in smpp_pdu.def, 
> I thought 
> it was enough.
> At least it works for me.
> 
> Oded Arbel wrote:
> 
> >For that we need to support optional fields in the SMPP 
> driver - its not as easy as it looks.
> >
> >--
> >Oded Arbel
> >m-Wise mobile solutions
> >[email protected]
> >
> >+972-9-9581711 (116)
> >+972-67-340014
> >
> >::..
> >Acting is not very hard.  The most important things are to be able to
> >laugh and cry.  If I have to cry, I think of my sex life.  
> And if I have
> >to laugh, well, I think of my sex life.
> >                -- Glenda Jackson
> >
> >
> >
> >  
> >
> >>-----Original Message-----
> >>From: David Chkhartishvili [mailto:[email protected]]
> >>Sent: Wednesday, October 16, 2002 1:03 PM
> >>To: Stipe Tolj
> >>Cc: Andreas Fink; [email protected]
> >>Subject: Re: Veto againt last smsc/smsc_smpp.c commit
> >>
> >>
> >>And one more time I want to discuss the way kannel currently gets 
> >>information about delivery status.
> >>Not all SMSC's return delivery status in deliver_sm pdu's 
> >>short_message 
> >>field.
> >>Instead, they use optional fields receipted_message_id and 
> >>receipted_message_id.
> >>I think it also shuld be configurable.
> >>
> >>
> >>Stipe Tolj wrote:
> >>
> >>    
> >>
> >>>>My SMSC also uses C octets.
> >>>>I think sms-id format (hex, dec or c octet) should be 
> >>>>        
> >>>>
> >>configurable (atm
> >>    
> >>
> >>>>only hex and dec).
> >>>>   
> >>>>
> >>>>        
> >>>>
> >>>agreed, we should take in account that SMSCs may return 
> msg id's that
> >>>are alphanumeric and hence don't fit the decimal or hex rules.
> >>>
> >>>Stipe
> >>>
> >>>[email protected]
> >>>-------------------------------------------------------------------
> >>>Wapme Systems AG
> >>>
> >>>Vogelsanger Weg 80
> >>>40470 Düsseldorf
> >>>
> >>>Tel: +49-211-74845-0
> >>>Fax: +49-211-74845-299
> >>>
> >>>E-Mail: [email protected]
> >>>Internet: http://www.wapme-systems.de
> >>>-------------------------------------------------------------------
> >>>wapme.net - wherever you are
> >>>
> >>> 
> >>>
> >>>      
> >>>
> >>-- 
> >>David Chkhartishvili
> >>Tel: 995 99 182418
> >>
> >>
> >>
> >>
> >>    
> >>
> >
> >
> >  
> >
> 
> 
> -- 
> David Chkhartishvili
> Tel: 995 99 182418
> 
> 
>