RE: [PATCH] smpp (sequence_id start with 1)

Hi all,

Oded, counter_increase() is a post-increment function: it returns the value
before incrementing.

Anyway, this fix was already posted by myself on Sep 06, and commited in
CVS.

See
http://www.kannel.3glab.org/cgi-bin/viewcvs.cgi/gateway/gw/smsc/smsc_smpp.c.
diff?r1=1.9&r2=1.10

Angel Fradejas
Mediafusión España, S.A.
[email protected]
www.mediafusion.es
Tel. +34 91 252 32 00
Fax +34 91 572 27 08



-----Mensaje original-----
De: [email protected] [mailto:[email protected]]En
nombre de Oded Arbel
Enviado el: jueves 24 de octubre de 2002 15:00
Para: Alexander Malysh; [email protected]
Asunto: RE: [PATCH] smpp (sequence_id start with 1)



-1 for that patch : in msg_to_pdu(), counter_increase is called before
calling pdu_create(), so the counter can never be 0 when pdu_create() is
entered.

--
Oded Arbel
m-Wise mobile solutions
[email protected]

+972-9-9581711 (116)
+972-67-340014

::..
Who's more foolish? The fool, or the one who follows him?"
	-- Ben Kenobi, "Star Wars"



> -----Original Message-----
> From: Alexander Malysh [mailto:[email protected]]
> Sent: Thursday, October 24, 2002 1:01 PM
> To: [email protected]
> Subject: [PATCH] smpp (sequence_id start with 1)
>
>
> Hi All,
>
> here is small bugfix.
>
> --
> Mit besten Grüßen aus Köln
>
> Dipl.-Ing.
> Alexander Malysh
> ___________________________________________
>
> Centrium GmbH
> Ehrenstraße 2
> 50672 Köln
>
> Fon: +49 (0221) 277 49 150
> Fax: +49 (0221) 277 49 109
>
> email: [email protected]
> web: www.centrium.de
>