RE: T68i as SMSC

Hello Oded,

I would say 'No', because it will make the
at2_pdu_decode_deliver_sm more robust.
Ok, it is not needed, because this crash only
happened because i hacked the switch statement
in at2_pdu_decode, but nevertheless...

Regards,

Peter


 


-----Original Message-----
From: Oded Arbel [mailto:[email protected]]
Sent: Mittwoch, 6. November 2002 14:46
To: Schaich, Peter; Kannel-devel (E-mail)
Subject: RE: T68i as SMSC




> -----Original Message-----
> From: Schaich, Peter [mailto:[email protected]]

> I now found the problem, it was a (simple) misconfiguration 
> of the SMSC: I added "no-smsc = true" (I've misinterpreted
> the user manual), but actually there was the smsc phone
> number in the PDU, so the at2_pdu_extract skipped
> the removal of the smsc phone number and the decode_deliver_sm()
> failed when looking at the TP-OA address.

Yes - both you and Markku Luosto are correct, I misinterpeted the PDU.
Should I revert thce changes I've made to the AT2 module ? the change was to
add

if (len > 20)
	goto msg_error;

and

if (pos > octstr_len(pdu)
	goto msg_error;

in couple of important places.

--
Oded Arbel
m-Wise mobile solutions
[email protected]

+972-9-9581711 (116)
+972-67-340014

::..
there are no big words, only little people