RE: kannel 1.2.1 crashes then dlr in use

Hello!

I use internal DLR storage everywhere. And I think we must change

            if ((typ & DLR_BUFFERED) && ((dlr_mask & DLR_SUCCESS) ||
(dlr_mask & DLR_FAIL))) {
to
            if ((typ & (DLR_BUFFERED || DLR_SMSC_SUCCESS)) && ((dlr_mask &
DLR_SUCCESS) || (dlr_mask & DLR_FAIL))) {

because i think no differense, in this case, between DLR_BUFFERED and
DLR_SMSC_SUCCESS. In both cases we must wait for
DLR_SUCCESS, DLR_FAIL or DLR_SMSC_FAIL. and no need to delete DLR from
list.
may be i'm miss.

with best wishes
 German Aksenov
phone: (095)258-7258 ext. 7836


                                                                                                                           
                      "Oded Arbel"                                                                                         
                      <[email protected]        To:       "German Aksenov" <[email protected]>, <[email protected]>   
                      >                        cc:                                                                         
                                               Subject:  RE: kannel 1.2.1 crashes then dlr in use                          
                      10.11.2002 08:49                                                                                     
                                                                                                                           
                                                                                                                           





> >If your waiting on SMSC_SUCCESS or SMSC_FAIL type delivery reports
(which
> >shouldn't happen generally - you'r supposed to put the message in to dlr
only
> >after you got SMSC_SUCCESS, and with SMSC_FAIL you don't put it in at
all),
> >then calling DLR with one of those will remove the DLR record from
storage.
> >
> >But thats all - no crash.
> ok. so, but then i'm wating for both DLR_SMSC_SUCCESS and DLR_SUCCESS
dlrmask=9,
> then after receiving DLR_SMSC_SUCCESS executed code
list_delete(dlr_waiting_list, i, 1);
> dlr_destroy(dlr); and may be it will be a problem in future (after
DLR_SUCCESS  received.)

Why are you waiting for DLR_SMSC_SUCCESS in the dlr code ? all drivers I
know that implement this functionality handle DLR_SMSC_SUCCESS internally
(as they should).

> note about crash: i think crash occured in part of smsc_emi2.c code

Sorry, don't know much about emi2.

--
Oded Arbel
m-Wise mobile solutions
[email protected]

+972-9-9581711 (116)
+972-67-340014

::..
"The complex-type shall be a simple-type."
  -- ISO 10206:1991 (Extended Pascal)