Re: [PATCH] Re: [FYI] smsbox routing patch commited

Hi ,

On Thursday 21 November 2002 01:01, Stipe Tolj wrote:
> > This is bad.. When did this creep into the CVS? "(null)" is *not* the
> > same as  NULL. I remember the patch (that is using "(null)") been
> > discussed on the list a while back, and I thought it was vetoed.
> > So I would vote +1 for this patch.
>
> it didn' "creap" in. We wanted to be sure that debug output lines that
> do octstr_get_cstr(octstr) return a string that can be displayed so
> that the analyzer of the logs knows that this has been a NULLed value
> instead of breaking everything up with if then clauses.

I think,  it's better to break this issue yet as to allow caller to think *all was fine* and pass NULL into
octstr_get_cstr (imho). Caller must always check if it's a NULL or not...

>
> I'd propose that any caller of octstr_get_cstr() may be aware that he
> should not call the function in case the octstr itself is anyway
> NULLed.
>
> Can any others that did the commit for "(null)" please heads up and
> comment on this.
>
> Stipe
>
> [email protected]
> -------------------------------------------------------------------
> Wapme Systems AG
>
> Vogelsanger Weg 80
> 40470 Düsseldorf
>
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
>
> E-Mail: [email protected]
> Internet: http://www.wapme-systems.de
> -------------------------------------------------------------------
> wapme.net - wherever you are

-- 
Mit besten Grüßen aus Köln

Dipl.-Ing.
Alexander Malysh
___________________________________

Centrium GmbH
Ehrenstrasse 2
50672 Köln

Fon: +49 (0221) 277 49 150
Fax: +49 (0221) 277 49 109

email: [email protected]
web: http://www.centrium.de