Re: repost: [PATCH] SMPP: data_coding (deliver_sm) votes?!

On Fri, 2002-11-22 at 21:04, Andreas Fink wrote:
> Why gsm_to_latin1 if we know encoding?

We don't, well the smpp driver doesn't - that's the whole point of this
patch. In the case where the data coding is set to SMSC default (0x00) -
the smpp driver doesn't know what decoding to do. We need to be able to
specify via the config what encoding each smsc coonsiders to be it's
default - they do vary. 

Currently all incomming are assumed to gsm hence gsm_to_latin1 encoding
is performed on all incomming messages from all smsc via smpp driver.
However, the SMSC default encoding could easily be ASCII, for example. 

-- consider --

If iconv is not available or no default is set via config and the data
coding is smsc default (0x00) - we assume gsm encoding so the default
behaviour is the same as current.

Alternatively, if iconv is not available and data coding requires iconv
or data coding is set via config to something which would require iconv,
we sould error and do no conversion (because we can't).

Otherwise - we utilise Oded's work with iconv to do sensible decoding of
incomming message.

Sound reasonable?

Cheers,
Alan