Re: [PATCH] store not critical fix

Alexander Malysh wrote:
> 
> Hi all,
> 
> and again small fix ;) Here is small fix for bb_store.

this is Alexander's patch:

Index: gw/bb_store.c
===================================================================
RCS file: /home/cvs/gateway/gw/bb_store.c,v
retrieving revision 1.16
diff -a -u -r1.16 bb_store.c
--- gw/bb_store.c	26 Aug 2002 14:10:10 -0000	1.16
+++ gw/bb_store.c	2 Dec 2002 18:40:34 -0000
@@ -393,10 +393,6 @@
 	    msgs++;
 	}
 	else if (msg_type(msg) == ack) {
-	    if (msg->sms.sms_type == report) {
-		octstr_destroy(pack);
-		continue;
-	    }
 	    key = octstr_format("%d-%d", msg->ack.time, msg->ack.id);
 	    dmsg = dict_remove(msg_hash, key);
 	    if (dmsg != NULL) 

seems reasonable to me. if msg_type() is ack, then we don't have any
msg->sms.xxx anyway. +1 from me. Can anyone please confirm this and
vote.

Stipe

[email protected]
-------------------------------------------------------------------
Wapme Systems AG

Vogelsanger Weg 80
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [email protected]
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are